Skip to content

Commit

Permalink
ANDROID-15374 divider implemented in informative sheet (#397)
Browse files Browse the repository at this point in the history
* ANDROID-15374 divider implemented in informative sheet

* ANDROID-15374 unused imports removed
  • Loading branch information
jmanriquehiberus authored Dec 4, 2024
1 parent 36a19aa commit d7574a8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ private fun ListInformative.toView(context: Context): View =
RecyclerView(context).also {
it.layoutManager = LinearLayoutManager(context)
it.adapter = InformativeListAdapter(this.elements.mapToInformativeViewData())
it.configureWithFullWidthLayout()
}

private fun BottomActions.toView(onSheetTapped: InternalOnSheetTapped, container: ViewGroup): View {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,7 @@ internal class InformativeListAdapter(val items: List<RowInformativeViewData>) :
}
}

if (position == items.size - 1) {
holder.bottomExtraSpace.visibility = View.VISIBLE
} else {
holder.bottomExtraSpace.visibility = View.GONE
}
holder.bottomExtraSpace.visibility = View.VISIBLE
}

override fun getItemCount(): Int = items.size
Expand Down
2 changes: 1 addition & 1 deletion library/src/main/res/layout/sheet_list_row_informative.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
<Space
android:id="@+id/sheet_row_informative_bottom_extra_space"
android:layout_width="match_parent"
android:layout_height="8dp"
android:layout_height="16dp"
android:visibility="visible"
app:layout_constraintTop_toBottomOf="@+id/sheet_row_action_text_barrier"
/>
Expand Down

0 comments on commit d7574a8

Please sign in to comment.