Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 11.0: use execjs <2.9.1 #566

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

ap-wtioit
Copy link
Contributor

to avoid "execjs requires Ruby version >= 2.5.0." errors.

execjs seens to have a new tag 2.9.1 that fails installing as a dependency of autoprefixer-rails on our CI with the following error:

...
#14 [base  5/18] RUN gem install --no-rdoc --no-ri --no-update-sources autoprefixer-rails --version '<9.8.6'     && gem install --no-rdoc --no-ri --no-update-sources bootstrap-sass --version '<3.4'     && rm -Rf ~/.gem /var/lib/gems/*/cache/
#14 55.10 ERROR:  Error installing autoprefixer-rails:
#14 55.10 	execjs requires Ruby version >= 2.5.0.
#14 ERROR: executor failed running [/bin/sh -c gem install --no-rdoc --no-ri --no-update-sources autoprefixer-rails --version '<9.8.6'     && gem install --no-rdoc --no-ri --no-update-sources bootstrap-sass --version '<3.4'     && rm -Rf ~/.gem /var/lib/gems/*/cache/]: runc did not terminate sucessfully
------
 > [base  5/18] RUN gem install --no-rdoc --no-ri --no-update-sources autoprefixer-rails --version '<9.8.6'     && gem install --no-rdoc --no-ri --no-update-sources bootstrap-sass --version '<3.4'     && rm -Rf ~/.gem /var/lib/gems/*/cache/:
#14 55.10 ERROR:  Error installing autoprefixer-rails:
#14 55.10 	execjs requires Ruby version >= 2.5.0.

Pinning the version to <2.9.1 fixes the issue for 11.0.Dockerfile

Info @wt-io-it

to avoid "execjs requires Ruby version >= 2.5.0." errors
@ap-wtioit ap-wtioit force-pushed the master-fix_11_0_gems_github branch 2 times, most recently from ea7ea11 to ddfbf3a Compare September 18, 2023 08:15
@ap-wtioit
Copy link
Contributor Author

Not 100% sure about d33df7f. I added it because installing docker-compose requires pyyaml < 6 and the install workaround yaml/pyyaml#736 does not work with poetry. (It always uses the newest Cython when installing pyyaml.)

@ap-wtioit ap-wtioit changed the title [IMP] 11.0: use execjs <2.9.1 [FIX] 11.0: use execjs <2.9.1 Sep 18, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good enough, thanks.

@pedrobaeza pedrobaeza merged commit f83cf41 into Tecnativa:master Sep 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants