Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and link reference in Integration Testing file (#2111) #2200

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

mai-repo
Copy link
Collaborator

@mai-repo mai-repo commented Jan 3, 2025

Summary:

This PR addresses issues related to missing reference links and some styling inconsistencies within the Integration Testing file.

Changes Made:

  • Fixed broken or missing links within the document.
  • Standardized link formatting for consistency across sections.
  • Fixed stylization throughout the file

Objective:

The objective of this PR is to resolve issues related to missing reference links and inconsistent styling throughout the Integration Testing file.

Next Steps:

@daaimah123, @mx-ruthie, @themagicianking -- please review the link changes in this file.

@mai-repo mai-repo added the current-cohort-participant the participants can work on this issue label Jan 3, 2025
@mai-repo mai-repo self-assigned this Jan 3, 2025
@mai-repo mai-repo changed the title Fix formatting and link reference in Integration Testing file (#2116) Fix formatting and link reference in Integration Testing file (#2111) Jan 3, 2025
Copy link
Collaborator

@themagicianking themagicianking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this is so much cleaner!

@mai-repo mai-repo removed the request for review from mx-ruthie January 3, 2025 17:37
Co-authored-by: Chris Jaure <[email protected]>
@efalsken
Copy link
Collaborator

efalsken commented Jan 3, 2025

In the future, to make it easier to review, it's sometimes useful to leave out some unnecessary changes. For example, changing the line length (wrapping) or whitespace indent (which there is a setting for) of every paragraph may be undesirable since it makes finding the actual typographical changes harder to spot during review. Moving that change to its own PR (reformatting the line lengths) where that is the only change, makes it clear and easy to review, since that will be the only change that we will be looking for.

@mai-repo
Copy link
Collaborator Author

mai-repo commented Jan 3, 2025

@efalsken Thanks for your feedback! I will implement those suggestions in the future 😊

@mai-repo mai-repo merged commit 8c02b06 into main Jan 3, 2025
@mai-repo mai-repo deleted the ticket2116 branch January 3, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current-cohort-participant the participants can work on this issue
Projects
Status: Implemented or Addressed ✅
Development

Successfully merging this pull request may close these issues.

Fix formatting and link references in integration testing topic outline
5 participants