Project Survey - Daniel Brobäck #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-and-cats
approved these changes
Mar 22, 2023
|
|
||
| return ( | ||
| <main> | ||
| {formStage > 0 && <ProgressBar progress={percent} />} |
There was a problem hiding this comment.
I really like this percent function, havent seen it before!
| <h1>Mentorship Sign Up</h1> | ||
| </div> | ||
| <div className="image-box"> | ||
| <picture> |
There was a problem hiding this comment.
is there a reason for calling 2 different pictures instead of resizing?
| </button> | ||
| )} | ||
| <form onSubmit={handleSubmit} required> | ||
| {formStage === 0 && ( |
There was a problem hiding this comment.
very nice solution on progressing the stages!
| Restart Form | ||
| </button> | ||
| )} | ||
| <form onSubmit={handleSubmit} required> |
There was a problem hiding this comment.
So cool that required works well! But is the "required" here needed as well as the required on the different inputs (for example row 105)? Are they both needed? If yes, what are they doing?
| )} | ||
| {formStage === 3 && ( | ||
| <div> | ||
| <h1>What time commitment can I make? /Hours a month/ *</h1> |
There was a problem hiding this comment.
super minor nitpicky thing, the user has been asked stuff as a "you" before this, and now an "I". Might be nice to be consistent :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://legendary-froyo-ff20a9.netlify.app/