Integrate ANDI-10625 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed |
kayoub5
reviewed
Nov 21, 2024
| @@ -36,6 +36,7 @@ struct flexray_frame | |||
| uint8_t cc; | |||
|
|
|||
| uint8_t data[254]; | |||
| uint8_t symbol_length; | |||
There was a problem hiding this comment.
In PCAP FlexRay symbol is defined as array of bytes, not just one value
|
The site explicitly states that a FR symbol frame has the measurement header of 1 byte and the symbol length of 1 byte, The SL[0..6] values represent a 7-bit unsigned integer (0-127). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flexray export function does not support flexray frames as of now. The struct and exporter function have been adapted to also support FlexRay symbols.