Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version_manifest_v2.json versions extraction #733

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Fix version_manifest_v2.json versions extraction #733

merged 1 commit into from
Sep 14, 2024

Conversation

EverNife
Copy link
Contributor

@EverNife EverNife commented Sep 14, 2024

The versions from https://launchermeta.mojang.com/mc/game/version_manifest_v2.js are now under {"versions":[]} field

https://launchermeta.mojang.com/mc/game/version_manifest_v2.json

image

Fixes #

  • Tested Changes using phpunit
  • Have read and followed the Contribution Guidelines

@Pyker Pyker self-assigned this Sep 14, 2024
@Pyker
Copy link
Member

Pyker commented Sep 14, 2024

That's a good catch, thank you.

@Pyker Pyker merged commit 2f69823 into TechnicPack:dev Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants