-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mod importing from Modrinth, Forge and Fabric #707
Open
rtm516
wants to merge
16
commits into
TechnicPack:main
Choose a base branch
from
rtm516:feature/mod-importing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this still beeing reviewd looks like a cool feature |
rtm516
force-pushed
the
feature/mod-importing
branch
4 times, most recently
from
October 27, 2023 09:37
f90a53e
to
162bd1e
Compare
(cherry picked from commit 162bd1e)
rtm516
force-pushed
the
feature/mod-importing
branch
from
October 27, 2023 12:42
162bd1e
to
e651570
Compare
Rebased for cleaner merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes N/A
Adds mod browsing and importing from Modrinth, along with importing of Forge and Fabric versions.
Known issues:
fabric.mod.json
) that has a newline in the middle of a string it will fail to load and therefor requires manual importing. This is due to the json file not following the official specifications, see https://stackoverflow.com/questions/34486346/new-lines-and-tabs-in-json-decode-php-7 for more infoScreenshots