fix: optimize mod list query

TechnicPack · Nov 29, 2024 · 1544ee5 · 1544ee5
1 parent dc4b4d6
commit 1544ee5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/app/Http/Controllers/ModController.php b/app/Http/Controllers/ModController.php
@@ -30,14 +30,7 @@ public function getIndex(): RedirectResponse
 
     public function getList(): View
     {
-        $mods = Mod::with(
-            [
-                'versions' => function ($query) {
-                    $query->orderBy('modversions.updated_at', 'desc');
-                },
-            ]
-        )
-            ->get();
+        $mods = Mod::with('latestVersion')->get();
 
         return view('mod.list')->with(['mods' => $mods]);
     }

diff --git a/app/Models/Mod.php b/app/Models/Mod.php
@@ -4,6 +4,7 @@
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\HasMany;
+use Illuminate\Database\Eloquent\Relations\HasOne;
 
 class Mod extends Model
 {
@@ -13,4 +14,9 @@ public function versions(): HasMany
     {
         return $this->hasMany(Modversion::class);
     }
+
+    public function latestVersion(): HasOne
+    {
+        return $this->hasOne(Modversion::class)->latestOfMany('updated_at');
+    }
 }
diff --git a/resources/views/mod/list.blade.php b/resources/views/mod/list.blade.php
@@ -47,7 +47,7 @@
                             @endif
                             <br>
                             <b>Latest
-                                Version:</b> {{ !$mod->versions->isEmpty() ? $mod->versions->first()->version : "N/A" }}
+                                Version:</b> {{ $mod->latestVersion ? $mod->latestVersion->version : "N/A" }}
                         </td>
                         <td>{{ !empty($mod->author) ? $mod->author : "N/A" }}</td>
                         <td>