Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reason to support wider boycott list #15

Merged
merged 2 commits into from
Jan 30, 2024
Merged

add reason to support wider boycott list #15

merged 2 commits into from
Jan 30, 2024

Conversation

THM222
Copy link
Contributor

@THM222 THM222 commented Jan 28, 2024

Addressing #14

Adding an other option for boycottt reasons outside occupation. Would it be better to add reasons like ceo_supports_israel, opposes_ceasefire?

change validation script to validate all in PR before exiting
@idris
Copy link
Contributor

idris commented Jan 28, 2024

Would it be better to add reasons like ceo_supports_israel, opposes_ceasefire?

Yes, I don't think we should allow "other", as it doesn't provide any information. I also think we should keep the reasons broad enough so that we don't have to create so many. The details will be in the description field.
So for sweetgreen, for example, maybe we add executives_support_israel. That makes it a bit more broad than ceo_supports_israel.

Edit: actually, I wonder if the Sweetgreen one belongs in something like hiring_discrimination (https://twitter.com/JonnyNemo/status/1711792010292572647)

@THM222
Copy link
Contributor Author

THM222 commented Jan 29, 2024

Edit: actually, I wonder if the Sweetgreen one belongs in something like hiring_discrimination (https://twitter.com/JonnyNemo/status/1711792010292572647)

nice! added both :)

i prefer the executive_supports rather than executives_support (former means at least one, latter implies many or all but it could be just one)

@THM222 THM222 merged commit f478606 into main Jan 30, 2024
4 checks passed
@THM222 THM222 deleted the add_reason branch January 31, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants