Skip to content

Commit

Permalink
Include test metadata in the results.json file (#5336)
Browse files Browse the repository at this point in the history
* Include metadata in results.json file:
- break up the jsonable logic for Metadata to its own function
- use this jsonable function when generating results.json

* Store test metadata array under the test_metadata key for consistency and clarity
  • Loading branch information
smathews-techempower authored and NateBrady23 committed Dec 22, 2019
1 parent 274b91e commit 16050cf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
14 changes: 10 additions & 4 deletions toolset/utils/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,12 @@ def parse_config(self, config, directory):

return tests

def list_test_metadata(self):
def to_jsonable(self):
'''
Prints the metadata for all the available tests
Returns an array suitable for jsonification
'''
all_tests = self.gather_tests()
all_tests_json = json.dumps(map(lambda test: {
return map(lambda test: {
"project_name": test.project_name,
"name": test.name,
"approach": test.approach,
Expand All @@ -256,7 +256,13 @@ def list_test_metadata(self):
"notes": test.notes,
"versus": test.versus,
"tags": hasattr(test, "tags") and test.tags or []
}, all_tests))
}, all_tests)

def list_test_metadata(self):
'''
Prints the metadata for all the available tests
'''
all_tests_json = json.dumps(self.to_jsonable())

with open(
os.path.join(self.benchmarker.results.directory,
Expand Down
1 change: 1 addition & 0 deletions toolset/utils/results.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ def __to_jsonable(self):
toRet['succeeded'] = self.succeeded
toRet['failed'] = self.failed
toRet['verify'] = self.verify
toRet['test_metadata'] = self.benchmarker.metadata.to_jsonable()

return toRet

Expand Down

0 comments on commit 16050cf

Please sign in to comment.