[wanna-do] やりたいことリストの追加ダイアログのベースを作った！ #63
+72
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoothezoo
changed the title
Izacchi16
reviewed
Sep 14, 2020
Comment on lines
50
to
51
| val newFragment = WannaDoDialogFragment() | ||
| newFragment.show(fragmentManager, "wannado_dialog") |
There was a problem hiding this comment.
個人的な好みですけど！
Suggested change
| val newFragment = WannaDoDialogFragment() | |
| newFragment.show(fragmentManager, "wannado_dialog") | |
| WannaDoDialogFragment().show(fragmentManager, "wannado_dialog") |
zoothezoo
force-pushed
the
feature/wanna-do-add-bottom-sheet
branch
from
6d8659e to
c7147f9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| }) | ||
| WannadoDataBindingViewController.ClickListener { | ||
| override fun onClicked(item: String) { |
There was a problem hiding this comment.
| Unexpected indentation (12) (should be 16) |
| WannadoDataBindingViewController.ClickListener { | ||
| override fun onClicked(item: String) { | ||
| val action = WannadoFragmentDirections.actionWannadoToWannadoDetail(item) | ||
| findNavController().navigate(action) |
There was a problem hiding this comment.
| Unexpected indentation (16) (should be 20) |
| findNavController().navigate(action) | ||
| } | ||
| }) | ||
| WannadoDataBindingViewController.ClickListener { |
There was a problem hiding this comment.
| Unexpected indentation (12) (should be 16) |
| }) | ||
| WannadoDataBindingViewController.ClickListener { | ||
| override fun onClicked(item: String) { | ||
| val action = WannadoFragmentDirections.actionWannadoToWannadoDetail(item) |
There was a problem hiding this comment.
| Unexpected indentation (16) (should be 20) |
| override fun onClicked(item: String) { | ||
| val action = WannadoFragmentDirections.actionWannadoToWannadoDetail(item) | ||
| findNavController().navigate(action) | ||
| } |
There was a problem hiding this comment.
| Unexpected indentation (12) (should be 16) |
| val action = WannadoFragmentDirections.actionWannadoToWannadoDetail(item) | ||
| findNavController().navigate(action) | ||
| } | ||
| }) |
There was a problem hiding this comment.
| Unexpected indentation (8) (should be 12) |
| adapter = wishListDataBindingViewController.adapter | ||
| layoutManager = LinearLayoutManager(context).apply { | ||
| orientation = LinearLayoutManager.VERTICAL | ||
| with(binding){ |
There was a problem hiding this comment.
| Missing spacing before “{“ |
| } | ||
| } | ||
| fabWannado.setOnClickListener { | ||
| WannaDoDialogFragment().show(requireActivity().supportFragmentManager, "wannado_dialog") |
There was a problem hiding this comment.
| Exceeded max line length (100) (cannot be auto-corrected) |
|
はちゃめちゃに怒られとるやんけ |
|
ktlintFormatだけかけてもらえればLGTM！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
なんでこの変更が必要だった？ (必須)
レイチェルのお願いは聞かなきゃだめでしょ
どんな変更した？ (必須)
DialogFragmentを用いて, ダイアログを表示しました！
どうやったらこの変更を確認できる？ (必須)
WannaDoFragmentでFAB押してください！
Screenshot
Notes(苦労したとこや参考にした記事など)