Dev: Upgrade Go compiler #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to correctly generate docs using latest library type comments. For example, the doc here [1] will only be added to `time.Location` type if the Kommentaar container is using the latest compiler version. Related to: Teamwork/projectsapigo#9197 https://github.com/Teamwork/projectsapigo/actions/runs/8279682137/job/22655306455?pr=9197 [1] https://github.com/golang/go/blob/go1.22.1/src/time/zoneinfo.go?name=release#L20-L22
Pull Request Test Coverage Report for Build 8281603129Details
💛 - Coveralls |
|
🤔 I will move this back to draft while I investigate the linter error |
|
Working now, ready for review. |
ripexz
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to generate docs using the latest library-type comments correctly.
For example, the doc here will only be added to
time.Locationtype if the Kommentaar container is using the latest compiler version.Related to:
https://github.com/Teamwork/projectsapigo/pull/9197
https://github.com/Teamwork/projectsapigo/actions/runs/8279682137/job/22655306455?pr=9197