Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katyara22 add button remove all waypoints #25

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Katyara22 add button remove all waypoints #25

merged 4 commits into from
Jul 9, 2024

Conversation

Katyara22
Copy link
Contributor

Hello,
I have a decade to add a button (remove all waypoints) because I have been playing with that mod. I like this mod but it pissed me off that I can't delete all the waypoints.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

bottomButtons = new ButtonList(buttonOptions, buttonAdd, buttonDimensions, buttonClose);
buttonList.addAll(bottomButtons);

init.run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these runnable? I am not a fan of that.

Copy link
Contributor Author

@Katyara22 Katyara22 Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a basic method defined the same logic for initializing 2 different Gui.
One Gui is the main initGui, and another method initConfirmGui it's a method for initializing confirming buttons to remove all waypoints.

I need to run this code because I don't want to repeat the same code.
It's allowed me to write that code.

    @Override
    public void initGui()
    {
        initBasicGui(() -> {
            // here is some code
            //For instance I init buttons which I need
        });
    }

    private void initConfirmGui()
    {
        initBasicGui(() -> {
            //Here another code
        });
    }

maybe it isn't correct in Java but I'm a .NET developer, so it looks correct to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get what it's doing and why.
Seems like a .net thing haha. it works, it's fine
Thanks for your submission, I will merge it an publish a new release

bottomButtons = new ButtonList(buttonOptions, buttonAdd, buttonDimensions, buttonClose);
buttonList.addAll(bottomButtons);

init.run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get what it's doing and why.
Seems like a .net thing haha. it works, it's fine
Thanks for your submission, I will merge it an publish a new release

@mysticdrew mysticdrew merged commit 48f429c into TeamJM:master Jul 9, 2024
2 checks passed
@mysticdrew
Copy link
Member

This has been published but under manual review on curseforge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants