Added translations as primary dimName source

[AnrDaemon]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[mysticdrew]

CLA needs to be signed

[mysticdrew]

Also, can you add a before and after screenshot of what this PR accomplishes?

[AnrDaemon]

Also, can you add a before and after screenshot of what this PR accomplishes?

Missing dimension provider data (unchanged from original behavior):

Original behavior (extra "overworld/superflat" dimension using FE multiworld module):

New behavior (extra dimension name is taken from custom resource pack):

[AnrDaemon]

I'm pondering an improvement to the caching mechanics.
It should purge the cache on server reconnect and resource pack reload.

[mysticdrew]

I'm pondering an improvement to the caching mechanics. It should purge the cache on server reconnect and resource pack reload.

We do not need a cache honestly.
It does not constantly poll this method.

[AnrDaemon]

Judging by the log (Constants.getString() log failures), it does.

[mysticdrew]

Judging by the log (Constants.getString() log failures), it does.

it shouldn't, I will fix that

[mysticdrew]

nevermind, I cannot easily fix that without some major refactoring. go ahead with your cache

[mysticdrew]

I'm pondering an improvement to the caching mechanics. It should purge the cache on server reconnect and resource pack reload.

purge it in
JourneymapClient#reset method.

Then somewhere you'll want to add.

        ((IReloadableResourceManager)  Minecraft.getMinecraft().getResourceManager()).registerReloadListener(iResourceManager -> {
           // purge cache
        });