Test PermutationImportance with XGBClassifier and pd.DataFrame issue#256 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for the test @harrysalmon . To the core devs on ELI5 - this test is a result of a "Make your firsts open source contribution" that I co-ran at PyDataLondon 2018 yesterday. Cheers! |
|
Great, thanks a lot for contributing the test @harrysalmon and for finding the issue @ianozsvald ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PermutationImportance.fitfails with XGBClassifier when passed a pandas Dataframe but fits when passed an numpy array.A test for the error in #256 @ianozsvald
May also be related to general xgb >= 0.7 issue #259