Fixed Import Warnings #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are there so many?
|
Consolidate your imports, please. EX: would become |
mfrancis33
reviewed
Jan 29, 2021
Comment on lines
+3
to
+4
| import edu.wpi.first.wpilibj2.command.CommandBase; | ||
| import edu.wpi.first.wpilibj2.command.ConditionalCommand; |
There was a problem hiding this comment.
Could this be changed to import edu.wpi.first.wpilibj2.command.*;?
mfrancis33
reviewed
Jan 29, 2021
| @@ -1,12 +1,14 @@ | |||
| package frc.robot.commands.auto.commandgroups.common.movement; | |||
|
|
|||
| import edu.wpi.first.wpilibj2.command.*; | |||
There was a problem hiding this comment.
Wouldn't this work instead of just the two classes being imported?
mfrancis33
reviewed
Jan 29, 2021
Comment on lines
+9
to
+12
| import frc.robot.commands.auto.AutoDriveWithJoystickInput; | ||
| import frc.robot.commands.auto.AutoRotateWithJoystickInput; | ||
| import frc.robot.commands.auto.AutoRotateWithVision; | ||
| import frc.robot.commands.auto.resetDriveEncoders; |
There was a problem hiding this comment.
Why uncondense it from import frc.robot.commands.auto.*;?
|
There seems to be a lot of import statements that could be condensed into, say, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed import warnings from 50+ files.