[REFACTOR] 회원의 방문 이력 테이블 추가 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unanchoi
approved these changes
May 29, 2024
Comment on lines
+26
to
+29
| public Visit(Member member) { | ||
| this.member = member; | ||
| this.visitedAt = LocalDateTime.now(); | ||
| } |
There was a problem hiding this comment.
로직에는 문제 없지만 생성자로 인스턴스 생성은 막아두고 static method나 builder로 인스턴스를 생성해도 괜찮을 것 같아요 ~ 큰 문제 없다고 판단되면 그대로 가셔도 좋습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚