[REFACTOR] 스웨거 응답 클래스 타입 명시

Team-Smeme · Mar 17, 2024 · bc023ad · bc023ad
1 parent bae3712
commit bc023ad
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 39 deletions.
diff --git a/smeem-api/src/main/java/com/smeem/api/common/BaseResponse.java b/smeem-api/src/main/java/com/smeem/api/common/BaseResponse.java
@@ -15,7 +15,11 @@ public record BaseResponse<T>(
 ) {
 
     public static <T> BaseResponse<T> of(String message, T data) {
-        return new BaseResponse<>(true, message, data);
+        return BaseResponse.<T>builder()
+                .success(true)
+                .message(message)
+                .data(data)
+                .build();
     }
 
     public static BaseResponse<?> of(boolean isSuccess, String message) {

diff --git a/smeem-api/src/main/java/com/smeem/api/common/ErrorResponse.java b/smeem-api/src/main/java/com/smeem/api/common/ErrorResponse.java
diff --git a/smeem-api/src/main/java/com/smeem/api/diary/api/DiaryApi.java b/smeem-api/src/main/java/com/smeem/api/diary/api/DiaryApi.java
@@ -1,15 +1,12 @@
 package com.smeem.api.diary.api;
 
 import com.smeem.api.common.BaseResponse;
-import com.smeem.api.common.ErrorResponse;
 import com.smeem.api.diary.api.dto.request.DiaryCreateRequest;
 import com.smeem.api.diary.api.dto.request.DiaryModifyRequest;
-import com.smeem.api.diary.api.dto.response.DiaryCreateResponse;
 import com.smeem.api.diary.api.dto.response.DiaryGetResponse;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.Parameter;
 import io.swagger.v3.oas.annotations.media.Content;
-import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.responses.ApiResponses;
 import io.swagger.v3.oas.annotations.tags.Tag;
@@ -38,25 +35,10 @@ public interface DiaryApi {
     @Operation(summary = "일기 상세 조회 API")
     @Parameter(name = "Authorization", description = "Bearer ${Smeem Access Token}", in = HEADER, required = true)
     @ApiResponses(value = {
-            @ApiResponse(
-                    responseCode = "201",
-                    description = "성공"
-            ),
-            @ApiResponse(
-                    responseCode = "4xx",
-                    description = "유효하지 않은 요청",
-                    content = @Content(schema = @Schema(implementation = ErrorResponse.class))
-            ),
-            @ApiResponse(
-                    responseCode = "401",
-                    description = "유효하지 않은 토큰",
-                    content = @Content(schema = @Schema(implementation = ErrorResponse.class))
-            ),
-            @ApiResponse(
-                    responseCode = "500",
-                    description = "서버 내부 오류",
-                    content = @Content(schema = @Schema(implementation = ErrorResponse.class))
-            )
+            @ApiResponse(responseCode = "201", description = "성공"),
+            @ApiResponse(responseCode = "4xx", description = "유효하지 않은 요청", content = @Content),
+            @ApiResponse(responseCode = "401", description = "유효하지 않은 토큰", content = @Content),
+            @ApiResponse(responseCode = "500", description = "서버 내부 오류", content = @Content)
     })
     ResponseEntity<BaseResponse<DiaryGetResponse>> getDiaryDetail(@PathVariable long diaryId);