[Feature/#53] Add container execution status to response #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitem4rk
reviewed
Oct 30, 2024
Comment on lines
105
to
108
| } catch (CustomException e) { | ||
| throw e; | ||
| } catch (Exception e) { | ||
| throw new CustomException(ErrorCode.SAVE_FAILED); | ||
| throw new CustomException(ErrorCode.SAVE_FAILED, e); |
There was a problem hiding this comment.
지웠어야 하는 코드인데 지워지지 않은 것 같습니다 삭제하도록 하겠습니다
Comment on lines
215
to
218
| containerResult.put("status", "success"); | ||
| containerResult.put("message", "Container started successfully."); | ||
| } catch (Exception e) { | ||
| containerResult.put("status", "failed"); |
There was a problem hiding this comment.
리터럴은 오타 방지를 위해 변수로 관리바랍니다.
|
테스트가 에러 처리에 대한 테스트일까요? 에러 처리에 대한 테스트는 진행했습니다 |
네 좋습니다. 수정하시고 바로 머지하셔도 될것같아요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Note