Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable fluid tank capacity #855

Draft
wants to merge 2 commits into
base: dev/1.21.1
Choose a base branch
from

Conversation

davidCMs
Copy link

@davidCMs davidCMs commented Oct 8, 2024

Description

Added option to change the fluid capacity of fluid tanks

@davidCMs davidCMs marked this pull request as draft October 9, 2024 12:21
@davidCMs
Copy link
Author

davidCMs commented Oct 9, 2024

seams i messed up something

@davidCMs
Copy link
Author

davidCMs commented Oct 9, 2024

okay from what i see to get this syncing properly on servers this would requre a rewrite of the fluid tanks witch i am to dumb to do so i am just going to leave this here if someone wants to pick it up and finish it. the config is there i just dont know how to sync the capacity over to the client

@davidCMs davidCMs changed the title Made the size of fluid tanks configurable Made the size of fluid tanks config Oct 9, 2024
@dphaldes
Copy link
Contributor

@davidCMs should we consider this PR as abandoned ?
Also, do explain what parts for tank needs refactoring.

@dphaldes dphaldes added Type-Enhancement New feature or enhancement to existing feature. P-2-Low Low priority. Not hurting anyone, just annoying. MC-1.21 labels Dec 15, 2024
@dphaldes dphaldes changed the title Made the size of fluid tanks config Configurable fluid tank capacity Dec 15, 2024
@davidCMs
Copy link
Author

davidCMs commented Dec 15, 2024

I just made the additions to the configs but i don't know how to make it work in multiplayer so as far as i know the tank classes need refactoring to sync the max capacity with the client but i am not familiar enough with forge to do that, i have looked at how the max energy config is done but i don't entirely understand how that works. I don't plan on editing this further i just left it here in case someone knows how to make it work in multiplayer so they have the configs all ready made .

@dphaldes dphaldes added the Status-Wontmerge This PR won't be merged, but is left now for reference of ongoing or future works. label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.21 P-2-Low Low priority. Not hurting anyone, just annoying. Status-Wontmerge This PR won't be merged, but is left now for reference of ongoing or future works. Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants