Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

어드민 상품 생성 시 이미지 추가 #261

Merged
merged 3 commits into from
Feb 7, 2024
Merged

어드민 상품 생성 시 이미지 추가 #261

merged 3 commits into from
Feb 7, 2024

Conversation

vanillacake369
Copy link
Collaborator

@vanillacake369 vanillacake369 commented Feb 6, 2024 •
edited
Loading

개요

어드민 상품 생성 시 이미지를 S3ImageService 를 통해 추가하였습니다.

작업사항

  • @Operation 을 통해 Swagger 메소드 설명 추가

  • AdminProductRequestDto 에 @Valid 추가

  • ProductCommandService 상품 저장 시, MultipartFile 이미지 저장

관련 이슈

@vanillacake369 vanillacake369 self-assigned this Feb 6, 2024
@vanillacake369 vanillacake369 added the enhancement New feature or request label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Test Results

95 tests   85 ✅  3s ⏱️
41 suites  10 💤
41 files     0 ❌

Results for commit 75da8af.

@vanillacake369 vanillacake369 marked this pull request as ready for review February 6, 2024 23:36
yunjae62
yunjae62 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@yunjae62 yunjae62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!!

@yunjae62 yunjae62 merged commit b47ed9d into main Feb 7, 2024
2 checks passed
@yunjae62 yunjae62 deleted the feat/admin-add-product-image branch February 7, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjae62 yunjae62 yunjae62 approved these changes

@Mayst1232 Mayst1232 Awaiting requested review from Mayst1232

@Binsreoun Binsreoun Awaiting requested review from Binsreoun

Assignees

@vanillacake369 vanillacake369

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

어드민 상품 생성 시 이미지 추가
2 participants
@vanillacake369 @yunjae62