구매 입찰 취소 기능 테스트 추가 #241
Merged
구매 입찰 취소 기능 테스트 추가 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results95 tests 85 ✅ 4s ⏱️ Results for commit a9c7fef. ♻️ This comment has been updated with latest results. |
vanillacake369
previously approved these changes
Feb 6, 2024
Comment on lines
+89
to
+96
| int start = (int) pageable.getOffset(); | ||
| int end = Math.min((start + pageable.getPageSize()), responseDtoList.size()); | ||
| Page<BuyPriceToQuantityResponseDto> responseDtoPage = new PageImpl<>(responseDtoList.subList(start, end), pageable, | ||
| responseDtoList.size()); | ||
|
|
||
| given(buyRepository.findAllPriceToQuantityOf(any(Product.class), any(Pageable.class))).willReturn(responseDtoPage); | ||
| // when | ||
| Page<BuyPriceToQuantityResponseDto> returnPage = buyQueryService.findAllBuyBidsOf(TEST_PRODUCT, pageable); |
There was a problem hiding this comment.
요부분 mockito 로 하시기 쉽지 않으셨을텐데 고생하셨네요 👍
| .buyId((long) i) | ||
| .price(1000L * i) | ||
| .discountPrice(1000L * i) | ||
| .coupon((i % 2 == 0) ? TEST_COUPON_FIX : null) |
There was a problem hiding this comment.
어떤 건 쿠폰주고 어떤 건 쿠폰 안 주게끔 하신걸까요??
구매 관련 조회 테스트 추가
즉시 구매 테스트 코드 작성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
구매 입찰 취소 기능 테스트 추가
작업사항
관련 이슈