Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare and_then/map/transform/map_error/or_else for SFINAE-friendliness #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Quuxplusone
Copy link

This incidentally simplifies the preprocessor stuff, by making these
codepaths look the same in both C++11 and C++14. The old code had the
weird effect that the C++11 codepath was slightly more SFINAE-friendly
than the C++14 codepath.

This patch doesn't actually make and_then/map/transform/map_error/or_else
be SFINAE-friendly. But it lays the groundwork for adding further
constraints to the enable_if stuff in and_then_impl etc., which
could make these functions fully SFINAE-friendly without needing to
touch the non-_impl versions again.

…ess.

This incidentally simplifies the preprocessor stuff, by making these
codepaths look the same in both C++11 and C++14. The old code had the
weird effect that the C++11 codepath was slightly *more* SFINAE-friendly
than the C++14 codepath.

This patch doesn't actually make and_then/map/transform/map_error/or_else
be SFINAE-friendly. But it lays the groundwork for adding further
constraints to the `enable_if` stuff in `and_then_impl` etc., which
could make these functions fully SFINAE-friendly without needing to
touch the non-`_impl` versions again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant