Remove mutable default args #2482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elayeek
force-pushed
the
remove_default_mutable_antipattern
branch
from
b40c109 to
b98d53b
Compare
This is a common pitfall in Python that causes unexpected behavior. Python evaluates functions on module load and generates mutable default argument objects once, then persist them whenever the function is called.
elayeek
force-pushed
the
remove_default_mutable_antipattern
branch
from
b98d53b to
4109bb4
Compare
tienne-B
approved these changes
Aug 13, 2024
Comment on lines
+16
to
+19
| # IDE files | ||
| .idea/ | ||
| .vscode/ | ||
|
|
There was a problem hiding this comment.
I think these could more efficiently be in your global gitignore, rather than being project-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common pitfall in Python that causes unexpected behavior.
Python evaluates functions on module load and generates mutable default argument objects once, then persist them whenever the function is called.
Fixes #2483