-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): adding NL outlines generation experimental feature #3055
Open
Sma1lboy
wants to merge
36
commits into
TabbyML:main
Choose a base branch
from
Sma1lboy:feature-generate-nl-outlines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lines generate with prompts
…geOutlines and adding auto choice visible range
- Updated imports to include `Uri`, `workspace`, and `WorkspaceEdit` from `vscode`. - Modified the `Outline` interface to include `startLine` and `endLine` instead of just `line`. - Added a new `CodeChangeRequest` interface. - Refactored the `provideNLOutlinesGenerate` method to improve readability and structure. - Enhanced logging for better debugging and tracking of document processing.
…NLOutlinesProvider
Sma1lboy
force-pushed
the
feature-generate-nl-outlines
branch
from
September 4, 2024 19:23
1526119
to
01d55d4
Compare
- Added `@types/diff` and `diff` to devDependencies. - Moved `openai` from dependencies to devDependencies. - Updated `diff` version in pnpm-lock.yaml.
- Removed code lens generation for outlines and confirmation commands. - Removed related prompt templates from AgentConfig
…ider - Added import for Diff module to handle code differences. - Enhanced logging for updateNLOutline method to track document and line number. - Improved error handling and logging for document opening and outline retrieval. - Updated the format of oldCode to include line numbers for better context. - Enhanced the handling of updated code received from the AI model, including removal of XML tags and proper line splitting.
- Introduced a progress notification during the NL Outline update process. - Added new commands for accepting and discarding NL Outline changes.
- Introduced `PendingChange` and `ChangesPreview` interfaces to manage pending changes and their previews. - Added `OpenAIResponse` type to handle asynchronous OpenAI responses. - Extended `NLOutlinesProvider` class to include new properties: `addedDecorationType`, `removedDecorationType`, `pendingChanges`, and `pendingCodeLenses`. - Implemented methods to create text editor decoration types for added and removed lines. - Added event listener for active text editor changes to clear all pending changes. - Updated `provideNLOutlinesGenerate` method to log additional information and notify listeners of CodeLenses change. - Removed unused `Command` import and `generateNLOutlinesRequest` method.
- Removed unnecessary parameters from `addAcceptDiscardCodeLens` method. - Updated command names for accept and discard actions. - Enhanced logging in `acceptChanges` method for better debugging. - Simplified the logic for applying edits and deleting extra lines.
…e unused parameter a
- Introduced a new configuration option `chat.outline` to enable/disable the 'Generate Outline' command. - Added getter and setter methods for `chat.outline` in the `Config` class. - Updated the command ID and title for generating outlines. - Modified the command palette configuration to conditionally show the 'Generate Outline' command based on the `chat.outline` setting.
wsxiaoys
requested changes
Sep 11, 2024
wsxiaoys
reviewed
Sep 11, 2024
wsxiaoys
reviewed
Sep 12, 2024
wsxiaoys
reviewed
Sep 12, 2024
fix: fix naming issue
Sma1lboy
force-pushed
the
feature-generate-nl-outlines
branch
from
September 17, 2024 06:16
2e0c0d7
to
c8ec0a3
Compare
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
reviewed
Sep 18, 2024
wsxiaoys
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just change everything nlOutline
-> outline
…tline generation and edit. Also change all `nlOutline` to `outline`
wsxiaoys
approved these changes
Sep 24, 2024
Sma1lboy
changed the title
feat(VSCode): Feature generate nl outlines
feat(vscode): Adding NL outlines generation experimental feature
Oct 25, 2024
Sma1lboy
changed the title
feat(vscode): Adding NL outlines generation experimental feature
feat(vscode): adding NL outlines generation experimental feature
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Example:
Example for visible range with offset
https://jam.dev/c/d299e35d-7442-4924-9f1c-dee7b430a6c5