Skip to content

Commit

Permalink
[FEATURE] Revert deep linking to record / field
Browse files Browse the repository at this point in the history
In commit #7ffd3b3 the navigation to forms of TCA records / fields
has changed from content frame deep linking to main frame deep linking.

This gets reverted with this patch, as content frame deep linking
is still supported in TYPO3 v11 LTS by adding a dummy `&token=x`
to the content frame url.
  • Loading branch information
linawolf committed Oct 31, 2021
1 parent 0e3e9d6 commit e91bbc0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 26 deletions.
3 changes: 0 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@
},
"extra": {
"patches": {
"typo3/cms-backend": {
"Dirty: Allow deep linking to show a single field of a record": "patches/EnableEditFormColumnsOnlyParam.patch"
},
"typo3/cms-core": {
"Dirty: Disable form protection for easy url hopping": "patches/DisableFormProtection.patch"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -465,11 +465,9 @@ public function goToRecord(string $table = '', int $uid = -1): void
}
[$table, $uid] = $this->resolveRecord($table, $uid);
$this->getWebDriver()->amOnPage(sprintf(
'/typo3/record/edit?edit[%s][%s]=edit',
'/typo3/record/edit?edit[%s][%s]=edit&token=x',
$table, $uid
));
$this->getWebDriver()->waitForElement('iframe[name="list_frame"]');
$this->switchToContentFrame();
$this->scrollModuleBodyToTop();
}

Expand Down Expand Up @@ -502,11 +500,9 @@ public function goToField(string $fields, string $table = '', int $uid = -1): vo
}
[$table, $uid] = $this->resolveRecord($table, $uid);
$this->getWebDriver()->amOnPage(sprintf(
'/typo3/record/edit?edit[%s][%s]=edit&columnsOnly=%s',
'/typo3/record/edit?edit[%s][%s]=edit&columnsOnly=%s&token=x',
$table, $uid, $fields
));
$this->getWebDriver()->waitForElement('iframe[name="list_frame"]');
$this->switchToContentFrame();
$this->scrollModuleBodyToTop();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function makeScreenshotOfRecord(string $fileName, string $table = '', int
if (!empty($selector)) {
$this->makeScreenshotOfElement($fileName, $selector, $altText, $captionText, $captionReference);
} else {
$this->makeScreenshotOfContentFrame($fileName, $altText, $captionText, $captionReference);
$this->makeScreenshotOfWindow($fileName, $altText, $captionText, $captionReference);
}
}

Expand Down Expand Up @@ -202,7 +202,7 @@ public function makeScreenshotOfField(string $fileName, string $fields, string $
if (!empty($selector)) {
$this->makeScreenshotOfElement($fileName, $selector, $altText, $captionText, $captionReference);
} else {
$this->makeScreenshotOfContentFrame($fileName, $altText, $captionText, $captionReference);
$this->makeScreenshotOfWindow($fileName, $altText, $captionText, $captionReference);
}
}

Expand Down
15 changes: 0 additions & 15 deletions patches/EnableEditFormColumnsOnlyParam.patch

This file was deleted.

0 comments on commit e91bbc0

Please sign in to comment.