[TASK] Raise phpstan level to 4 (#267)

There were no additional errors on level 3. Add non-usage of exampleConfiguration to baseline as this is an example of fetching the config.
TYPO3-Documentation · May 4, 2024 · 51cbce2 · 51cbce2
1 parent b4e4df9
commit 51cbce2
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon
@@ -1,5 +1,10 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#^Property T3docs\\\\Examples\\\\Controller\\\\ModuleController\\:\\:\\$exampleConfig is never read, only written\\.$#"
+			count: 1
+			path: ../../Classes/Controller/ModuleController.php
+
 		-
 			message: "#^Access to an undefined property T3docs\\\\Examples\\\\Xclass\\\\NewRecordController\\:\\:\\$content\\.$#"
 			count: 1

diff --git a/Build/phpstan/phpstan.neon b/Build/phpstan/phpstan.neon
@@ -3,7 +3,7 @@ includes:
 
 parameters:
   phpVersion: 80200
-  level: 2
+  level: 4
 
   bootstrapFiles:
     - phpstan-typo3-constants.php

diff --git a/Classes/Http/MeowInformationRequester.php b/Classes/Http/MeowInformationRequester.php
@@ -62,7 +62,10 @@ public function request(): string
         }
         // Get the content as a string on a successful request
         $content = $response->getBody()->getContents();
-        return (string)json_decode($content, true, flags: JSON_THROW_ON_ERROR)['fact'] ??
+        $result = json_decode($content, true, flags: JSON_THROW_ON_ERROR);
+        if (!is_array($result) || !isset($result['fact']) || !is_scalar($result['fact'])) {
             throw new \RuntimeException('The service returned an unexpected format.', 1666413230);
+        }
+        return (string)$result['fact'];
     }
 }
diff --git a/Classes/LinkHandler/GitHubLinkHandler.php b/Classes/LinkHandler/GitHubLinkHandler.php
@@ -73,8 +73,16 @@ public function canHandleLink(array $linkParts): bool
      */
     public function formatCurrentUrl(): string
     {
-        return 'https://github.com/' . $this->configuration['project'] . '/'
-            . $this->configuration['action'] . '/' . $this->linkParts['issue'] ?? '';
+        $issue = '';
+        if (isset($this->linkParts['issue'])) {
+            $issue = $this->linkParts['issue'];
+        }
+        return sprintf(
+            'https://github.com/%s/%s/%s',
+            $this->configuration['project'],
+            $this->configuration['action'],
+            $issue,
+        );
     }
 
     /**