Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Fix example explanation #84

Closed
wants to merge 1 commit into from
Closed

Conversation

a-v-l
Copy link

@a-v-l a-v-l commented Jun 11, 2024

Add the wrapping ### to the example

Add the wrapping ### to the example
@froemken
Copy link

Not tested yet, but in core I found these lines:
https://github.com/TYPO3/typo3/blob/main/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L3159-L3167
It looks like a plain replacement.

I remember the old marker based ### replacement, but that was called constants which was deprecated in TYPO3 12 and removed in TYPO3 13:
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.1/Deprecation-99040-DeprecatedTypoScriptSetupConstantsTop-level-object.html#migration

@froemken
Copy link

Hello @a-v-l

thank you for your help to make TYPO3 documentation a better place, but I can't merge that patch, as short is a plain replacement without old ### markers. I have just tested it. I think you mixed up it with the good old parseFunc.constants

Thank you for your help

Stefan

@froemken froemken closed this Jun 11, 2024
@a-v-l
Copy link
Author

a-v-l commented Jun 12, 2024

Hey @froemken,

thank you for reviewing my pull request. I found the information about short in the TypoScript Reference. I haven't tested it myself, but if you are right, the reference is wrong or outdated.

@froemken
Copy link

Hey @a-v-l

thank you for that hint. I have created a PR for that here:
TYPO3-Documentation/TYPO3CMS-Reference-Typoscript#1280

Stefan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants