Test Service for latest secure TYPO3 core #76
Conversation
| @@ -75,10 +77,40 @@ public static function updateLatestTypo3VersionRegistry() | |||
| if (is_array($details) && !empty($details['stable'])) { | |||
| $stable[$major] = $details['stable']; | |||
| } | |||
| if (is_array($details) && is_array($details['releases'])) { | |||
| $found = false; | |||
There was a problem hiding this comment.
This variable is not necessary. Just set $security[$major] to the latest before the loop.
| @@ -75,10 +77,40 @@ public static function updateLatestTypo3VersionRegistry() | |||
| if (is_array($details) && !empty($details['stable'])) { | |||
| $stable[$major] = $details['stable']; | |||
| } | |||
| if (is_array($details) && is_array($details['releases'])) { | |||
| $found = false; | |||
| $latestCheckedVersion = ''; | |||
| break; | ||
| } | ||
| // if versionDetails->type === 'security' then this is the security update; stop searching | ||
| if (self::extractBugfixNumberFromVersion($version) === 0) { |
There was a problem hiding this comment.
Any reason why you don't use \TYPO3\CMS\Core\Utility\VersionNumberUtility::convertVersionStringToArray?
| $latestCheckedVersion = $version; | ||
| // if major version > latest_lts check if bugfix part of version number == '0'; | ||
| // in that case this is the security update and stop searching | ||
| if (version_compare($major, $latestLts, '>')) { |
There was a problem hiding this comment.
Isn't the fist version in releases always the one to choose for $major > $lts?
There was a problem hiding this comment.
What is the intention of checking $major > $latestLts at all?
| } | ||
| \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\CMS\Core\Registry')->set('tx_caretaker', 'TYPO3versions', $max); | ||
| \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\CMS\Core\Registry')->set('tx_caretaker', 'TYPO3versionsStable', $stable); | ||
|
|
||
| \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\CMS\Core\Registry')->set('tx_caretaker', 'TYPO3versionsSecurity', $security); |
There was a problem hiding this comment.
Please split these three lines. First get the registry object, then use it to store all three information.
| * @param string $version | ||
| * @return integer | ||
| */ | ||
| protected static function extractBugfixNumberFromVersion($version) |
|
@jvanderkroon could you please fix the code style issues and check @IchHabRecht 's comments? |
|
patch continued in #88 |
|
solves #63 |
Applied patch from https://forge.typo3.org/issues/58828#change-321465…
#63