forked from autonomousapps/dependency-analysis-gradle-plugin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ProjectDependency.path
instead of ProjectDependency.dependencyProject.path
on Gradle 8.11
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
changed the title
Add 8.11 to versions
Use ProjectDependency.path instead of ProjectDependency.dependencyProject.path on Gradle 8.11
Nov 1, 2024
TWiStErRob
changed the title
Use ProjectDependency.path instead of ProjectDependency.dependencyProject.path on Gradle 8.11
Use Nov 1, 2024
ProjectDependency.path
instead of ProjectDependency.dependencyProject.path
on Gradle 8.11
TWiStErRob
commented
Nov 1, 2024
TWiStErRob
commented
Nov 1, 2024
@@ -26,7 +26,7 @@ abstract class AbstractFunctionalSpec extends Specification { | |||
protected static final SUPPORTED_GRADLE_VERSIONS = [ | |||
GradleVersions.minGradleVersion, | |||
GRADLE_LATEST, | |||
// GRADLE_8_11, | |||
GRADLE_8_11, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
GRADLE_8_11, | |
// GRADLE_8_11, |
TWiStErRob
commented
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figure out if this is published or just build logic. If published needs if
too.
w: testkit/gradle-testkit-plugin/src/main/kotlin/com/autonomousapps/GradleTestKitSupportExtension.kt:211:24 'val dependencyProject: Project!' is deprecated. Deprecated in Java. w: testkit/gradle-testkit-plugin/src/main/kotlin/com/autonomousapps/GradleTestKitSupportExtension.kt:212:21 'val dependencyProject: Project!' is deprecated. Deprecated in Java.
> Configure project :build-logic:convention w: build-logic/convention/build.gradle.kts:17:3: 'kotlinOptions(KotlinJvmOptionsDeprecated /* = KotlinJvmOptions */.() -> Unit): Unit' is deprecated. Please migrate to the compilerOptions DSL. More details are here: https://kotl.in/u1r8ln
> Configure project :testkit:gradle-testkit-plugin Using a toolchain installed via auto-provisioning, but having no toolchain repositories configured. This behavior is deprecated. Consider defining toolchain download repositories, otherwise the build might fail in clean environments; see https://docs.gradle.org/8.11-rc-3/userguide/toolchains.html#sub:download_repositoriesed artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes autonomousapps#1305
https://github.com/gradle/gradle/blob/2cfa6473bce73ae81838f8e8bd83d74ad7dd6e5b/subprojects/core-api/src/main/java/org/gradle/api/artifacts/ProjectDependency.java#L39
Recommended to look at individual commits for motivation of changes.