Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NPM lockfile #4

Closed
wants to merge 1 commit into from
Closed

add NPM lockfile #4

wants to merge 1 commit into from

Conversation

jvictors-tp
Copy link

In this commit, I add an NPM lockfile.

This will help tie us to a reproductable and consistent set of dependencies for better QA. This will also improve our security as the latest versions of packages might not be as reliable or secure. I'll keep an eye on this and package.json with several tools going forward.

Copy link
Collaborator

@jstayton jstayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jesse – My understanding is that libraries like this one – that you add as a dependency to your own app – shouldn't have the package-lock.json file under version control. For example, got and file-type.

If the thinking has changed on this, let me know!

@jstayton
Copy link
Collaborator

Based on your comment in QueryQL, I'm going to go ahead and close this one too.

@jstayton jstayton closed this Nov 28, 2023
@jstayton jstayton deleted the jvictors-new-lockfile branch December 5, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants