Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and clean up in det_manip #974

Open
wants to merge 24 commits into
base: unstable
Choose a base branch
from
Open

Update and clean up in det_manip #974

wants to merge 24 commits into from

Conversation

Thoemi09
Copy link
Contributor

@Thoemi09 Thoemi09 commented Dec 4, 2024

The following has been done:

  • Added documentation and renamed variables accordingly
  • Introduced operation specific work data
  • Added missing +/-1 factors to the remove operations
  • Updated tests
  • Removed unused/unnecessary members from the det_manip class
  • General clean up and code modernization

@Thoemi09
Rename function_arg_ret_type to callable_traits
5ee4b13
@Thoemi09
Format det_manip.hpp
b719697
@Thoemi09
Add utils.hpp to det_manip
8bb40d8
@Thoemi09
Move work data in det_manip to work_data.hpp
015470e
@Thoemi09
Remove swap and custom copy and move operations in det_manip
44790bf
@Thoemi09
Clean up typedefs in det_manip
a5139d0
@Thoemi09
Restructure det_manip class without changing any implementation details
7346e73
@Thoemi09
Add docs and rename member variables in det_manip
2f89358
@Thoemi09
Update constructors, reserve and clear in det_manip
48fe57f
@Thoemi09
Update getter/setter methods in det_manip
9ffd202 
Reintroduce foreach for det_manip
@Thoemi09
Update regenerate and check methods in det_manip
8468853
@Thoemi09
Update remove operations in det_manip and add tests
0888bbc 
- introduce remove specific working data
- fix an inconsistency with a factor of +/-1 in the cached determinant and sign
- add docs and rename variable to make them consistent with the docs
@Thoemi09
Update insert operations in det_manip and add tests
b8a8142 
- introduce insert specific working data
- add docs and rename variables to make them consistent with the docs
@Thoemi09
Update swap operations in det_manip and add tests
1593972
@Thoemi09
Update roll operation in det_manip and add tests
0d64b4c
@Thoemi09
Update change row/col operations in det_manip and add tests
5c51e0c 
- introduce change row/col specific working data
@Thoemi09
Update refill operations in det_manip and add tests
5da019f 
- introduce refill specific working data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Thoemi09