Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted Tailfit #789

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Weighted Tailfit #789

wants to merge 4 commits into from

Conversation

hschnait
Copy link

Dear all

This PR implements the weighted tailfit originally proposed by @gkraberger (PR #482), that got lost during the rework of the tails in 2.x (see also #719).

Please review whether you want to add it in this way - or if I'm messing with something I should not mess with here.
The default behaviour of the tailfit does not change, the order of the error can be set by set_tail_fit_parameters.

@the-hampel
Copy link
Member

@Wentzell can we pick this up again and maybe merge? I thing this might be a very useful feature, because the default tail fit by fraction is rather useless at the moment without weighting by frequencies, as the tail fit is dominated by Gf elements from frequencies with very larger error. I checked a bit the commits, and the changes seem to be rather small and do not break any backward compatibility if I see this correctly.

@Wentzell
Copy link
Member

Yes we should definitely pick this up again!

The current implementation is a bit stringent as it limits you to a particular analytic form for the fitting weights.
We should generalize and have the user provide a function that returns the weight based on Matsubara index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants