Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils for py3.12 compatibility #43

Merged
merged 2 commits into from
May 27, 2024

Conversation

Thoemi09
Copy link
Collaborator

No description provided.

@Wentzell Wentzell requested a review from HugoStrand October 16, 2023 16:10
@Thoemi09
Copy link
Collaborator Author

Thoemi09 commented Oct 16, 2023

In the second commit, I have removed numpy_compat.py since (as far as I know) it only checks if the numpy version is >= 1.8, which is lower than the actual triqs requirement for numpy, i.e. 1.11.

@Thoemi09
Copy link
Collaborator Author

For now, we can use setuptools as a workaround, since it ships the distutils package. In this case, we don't have to change anything in the repo.

Once we make the switch to clair (instead of cpp2py), we can check the numpy version directly in TRIQS with cmake. If we decide to only support numpy versions >= 1.8, we could merge this PR in the future.

Copy link
Member

@Wentzell Wentzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Thoemi09 for these improvements!

@Wentzell Wentzell merged commit a22195f into TRIQS:unstable May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants