Adding support for Basic Authentication workflow #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a link to the RFC you mentioned? |
|
Also, can you also provide some JRXML so that we can see in which expressions you are using this feature and what type of value the expression has? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a bug in production where assets for reports weren't loading when a url in the form of http://{user}:{password}@www.myurl.com. According the RFC, this is a legal URL format and browsers such as chrome will automatically handle the addition of the request headers without intervention from the user. The current code doesn't send up any headers at all.
This PR will allow for the loading of objects where the URL is in the above form.