Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dimension separator in arrays instead of FSStore #52

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

sanath-2024
Copy link
Contributor

Move all usage of dimension_separator from Zarr stores to individual Zarr arrays, in order to avoid .zmetadata dimension separator bug

@tasansal tasansal added the bug Something isn't working label Sep 6, 2022
@tasansal tasansal self-requested a review September 6, 2022 15:59
@tasansal tasansal changed the title Dimension separator bug fix FSStore dimension separator bug workaround Sep 6, 2022
@tasansal tasansal changed the title FSStore dimension separator bug workaround Use dimension separator in arrays instead of FSStore Sep 6, 2022
@tasansal
Copy link
Collaborator

tasansal commented Sep 6, 2022

Thanks @sanath-2024. I will run some cloud ingestion tests and then merge if everything works as expected.

This PR is related to #43

@srib
Copy link
Contributor

srib commented Sep 6, 2022

Closes #42

@srib srib linked an issue Sep 6, 2022 that may be closed by this pull request
.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Altay Sansal <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #52 (bde1944) into main (6f0372c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files          43       43           
  Lines        1583     1583           
  Branches      203      203           
=======================================
  Hits         1280     1280           
  Misses        267      267           
  Partials       36       36           
Impacted Files Coverage Δ
src/mdio/api/io_utils.py 61.53% <ø> (ø)
src/mdio/converters/segy.py 76.56% <ø> (ø)
src/mdio/segy/blocked_io.py 90.16% <ø> (ø)
tests/unit/conftest.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tasansal tasansal merged commit f580e2d into TGSAI:main Sep 6, 2022
@tasansal tasansal mentioned this pull request Sep 6, 2022
@tasansal
Copy link
Collaborator

tasansal commented Sep 6, 2022

thanks @sanath-2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for backward compatibility
4 participants