Interface: Fix memory leak on opening ROMs, added function to manually free ROMs #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2022
rofl0r
reviewed
Mar 30, 2022
rofl0r
reviewed
Mar 30, 2022
theCapypara
force-pushed
the
freeing-roms
branch
from
a8f6438
to
66c8f91
Compare
rofl0r
reviewed
May 19, 2022
| clear_savestates(); | ||
| i = NDS_LoadROM(filename); | ||
| if (i > 0) { | ||
| rom_opened = true; |
There was a problem hiding this comment.
if rom_opened was already true, it will stay true even if i <= 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side note, at a quick glance it seems that this also affects the Windows and Linux GUI frontends (didn't check Mac), since I couldn't find
NDS_FreeROM();being called there when opening a new ROM. The Windows GUI only seems to free the old ROM when explicitly told to close the ROM. However this is only from a quick glance at the code, I didn't actually do more investigation, but it might be worth to check.