Fix "missing interrupt" and truncated register reads in TDC7200 driver code #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2020 17:15
The TDC7200 code uses a bogus work-around for not receiving an interrupt for a completed measurement. Fixed by actually enabling the necessary interrupt and adding code to acknowledge and clear all interrupt conditions after reading each measurement Signed-off-by: Matthias Welwarsky <[email protected]>
In the readReg24() method, the variable "msb" is a 16bit unsigned int which gets shifted beyond its size, effectively clearing the MSB of each register read. Fix by casting it to an uint32_t. Signed-off-by: Matthias Welwarsky <[email protected]>
|
These both look good to me. |
n8ur
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Hi Matthias --
Finally doing a bit of maintenance and I have made the correction to readReg24() you proposed but I did it via manual patch rather than pull. Per our email messages, I'm not making the interrupt changes, but still plan to investigate whether there's something stupid that I've been missing that causes the problem.
Thanks!
John
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two bugs in the tdc7200 driver, the first one concerning the missing interrupts for measurement completion, the second one about truncated 24 bit register reads. Please consider merging them with your master branch.