Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: c-card image link selector too broad #421

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: c-card image link selector too broad #421

merged 1 commit into from
Nov 4, 2024

Conversation

wesleyboar
Copy link
Member

Overview

Broad selector was affecting links and images outside c-card.

Related

Changes

  • changed (custom) selector to be more specific

Testing

  1. Card image links should have zero UI/UX change.
    Compare to enhance(card): linked images #419.

UI

Skipped.

@wesleyboar wesleyboar merged commit 3bab959 into main Nov 4, 2024
1 check passed
@wesleyboar wesleyboar deleted the fix/c-card-image-link-slector-too-broad branch November 4, 2024 22:26
@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Nov 4, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar