Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVERT task/tup-534 Adds in media query for tables #313

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2024

Overview

#275 is not backward compatible. Revert it.

Related / Changes

Testing & UI

This is what I found that showed #275 is not backwards-compatible.

fails without new class existing tables will break works only with new class
secret class missing existing tables will break secret class required

@wesleyboar wesleyboar merged commit 39b960d into main Mar 1, 2024
1 of 3 checks passed
@wesleyboar wesleyboar deleted the task/tup-534--revert branch March 1, 2024 22:28
@wesleyboar wesleyboar changed the title Task/tup 534 revert REVERT task/tup-534 Adds in media query for tables Mar 1, 2024
@wesleyboar wesleyboar added patch A backward-compatible fix fix Fixes user-facing behavior or feature labels Mar 1, 2024
wesleyboar added a commit that referenced this pull request Mar 12, 2024
@wesleyboar
Copy link
Member Author

Code is restored (i.e. this PR is "un-reverted") in #317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant