WP-547: case insensitive email in GET tickets (#944)

* WP-547: case insensitive email in GET tickets

* Do not assume ticket fields are a list.

* lint fix

* Fix redundancy

server/portal/apps/tickets/rtUtil.py

@@ -60,11 +60,21 @@ def replyToTicket(self, ticket_id, reply_text, files=[]):
     def hasAccess(self, ticket_id, user=None):
         if user and ticket_id:
             ticket = self.tracker.get_ticket(ticket_id)
-            if user in ticket.get('Requestors', '') or user in ticket.get('Cc', ''):
+            if DjangoRt.contains_user(ticket.get('Requestors', ''), user) or DjangoRt.contains_user(ticket.get('Cc', ''), user):
                 return True
 
         return False
 
     def getAttachment(self, ticket_id, attachment_id):
         ticketAttachment = self.tracker.get_attachment(ticket_id, attachment_id)
         return ticketAttachment
+
+    @staticmethod
+    def contains_user(ticket_field_data, user):
+        user_lower = user.lower()
+
+        if isinstance(ticket_field_data, str):
+            return user_lower in ticket_field_data.lower()
+        elif isinstance(ticket_field_data, list):
+            return user_lower in map(str.lower, ticket_field_data)
+        return user_lower in ticket_field_data

server/portal/apps/tickets/unit_test.py

@@ -2,6 +2,7 @@
 from django.http import HttpResponse
 from django.http import HttpRequest
 from portal.apps.tickets.utils import get_recaptcha_verification
+from portal.apps.tickets import rtUtil
 
 
 @pytest.fixture(autouse=True)
@@ -46,3 +47,61 @@ def test_get_recaptcha_verification(mocker, requests_mock, regular_user):
     request.POST['recaptchaResponse'] = 'string'
     result = get_recaptcha_verification(request)
     assert result['success'] == recaptchaSuccess['success']
+
+
+class RtUtilTestable(rtUtil.DjangoRt):
+    '''
+    Tester for rtUtil.DjangoRt.
+    '''
+
+    def __init__(self, tracker):
+        # Set the attributes directly
+        self.rtHost = 'mock_host'
+        self.rtUn = 'mock_rt_user'
+        self.rtPw = 'mock_pw'
+        self.rtQueue = ''
+        self.tracker = tracker
+
+
+@pytest.fixture
+def rt_ticket(request):
+    return request.param
+
+
+@pytest.fixture
+def mock_tracker(mocker, rt_ticket):
+    mock_tracker = mocker.MagicMock()
+    mock_tracker.get_ticket.return_value = rt_ticket
+    yield mock_tracker
+
+
+@pytest.mark.parametrize('rt_ticket', [
+    {'id': 1, 'Requestors': ["[email protected]", "[email protected]"], 'Cc': []},
+    {'id': 1, 'Requestors': "[email protected],[email protected]", 'Cc': []},
+    {'id': 1, 'Requestors': ["[email protected]", "[email protected]"], 'Cc': []}], indirect=True)
+def test_rt_hasaccess_requestors_or_cc(mock_tracker):
+    rtTester = RtUtilTestable(mock_tracker)
+    assert rtTester.hasAccess(1, '[email protected]') is True
+    assert rtTester.hasAccess(1, '[email protected]') is True
+
+
+@pytest.mark.parametrize('rt_ticket', [
+    {'id': 1, 'Requestors': ["[email protected]"], 'Cc': ["[email protected]", "[email protected]"]},
+    {'id': 1, 'Requestors': ["[email protected]"], 'Cc': "[email protected],[email protected]"},
+    {'id': 1, 'Requestors': ["[email protected]"], 'Cc': ["[email protected]", "[email protected]"]},
+    {'id': 1, 'Cc': ["[email protected]", "[email protected]"]},
+    {'id': 1, 'Requestors': [], 'Cc': ["[email protected]", "[email protected]"]}], indirect=True)
+def test_rt_hasaccess_cc(mock_tracker):
+    rtTester = RtUtilTestable(mock_tracker)
+    assert rtTester.hasAccess(1, '[email protected]') is True
+    assert rtTester.hasAccess(1, '[email protected]') is True
+
+
+@pytest.mark.parametrize('rt_ticket', [
+    {'id': 1, 'Requestors': ["[email protected]"], 'Cc': ["[email protected]"]},
+    {'id': 1, 'Requestors': ["[email protected]"], 'Cc': ["[email protected]"]},
+    {'id': 1},
+    {'id': 1, 'Requestors': [], 'Cc': []}], indirect=True)
+def test_rt_hasnoaccess(mock_tracker):
+    rtTester = RtUtilTestable(mock_tracker)
+    assert rtTester.hasAccess(1, '[email protected]') is False