-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WP-197 migrate frontera portal #293
Open
wesleyboar
wants to merge
65
commits into
main
Choose a base branch
from
feat/WP-197-migrate-frontera
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
feat(frontera): WP-19 migrate
feat: WP-19 migrate frontera portal
Jul 9, 2024
wesleyboar
changed the title
feat: WP-19 migrate frontera portal
feat: WP-197 migrate frontera portal
Jul 9, 2024
Apply colors to anonymous layer.
…MS-Custom into feat/WP-197-migrate-frontera
wesleyboar
force-pushed
the
feat/WP-197-migrate-frontera
branch
from
July 25, 2024 17:58
833a53c
to
31bc419
Compare
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Jul 25, 2024
Frontera migration — TACC/Core-CMS-Custom#293 — uses @layers, but then Frontera styles yield to Core-CMS styles. They yield because Core-CMS — with `TACC_CORE_STYLES_VERSION=2` — has all its styles in an anonymous layer. (CSS in an anonymous layer beats CSS in a named layer.)
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Jul 25, 2024
Frontera migration — TACC/Core-CMS-Custom#293 — uses @layers, but then Frontera styles yield to Core-CMS styles. They yield to Core-CMS because Core-CMS — with `TACC_CORE_STYLES_VERSION=0` — has all its styles in an anonymous layer. (CSS in an anonymous layer beats CSS in a named layer.)
wesleyboar
force-pushed
the
feat/WP-197-migrate-frontera
branch
from
September 23, 2024 20:39
f8cedf4
to
b9be16a
Compare
removes: - config-css - prebuild - gitignore - js-yaml
UNTESTED!
This reverts commit afe0884.
…MS-Custom into feat/WP-197-migrate-frontera
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Oct 1, 2024
* feat: WP-197 use @layer's / help migrate Frontera Frontera migration — TACC/Core-CMS-Custom#293 — uses @layers, but then Frontera styles yield to Core-CMS styles. They yield to Core-CMS because Core-CMS — with `TACC_CORE_STYLES_VERSION=0` — has all its styles in an anonymous layer. (CSS in an anonymous layer beats CSS in a named layer.) * fix: #s-header .nav-link hover underline * fix: #s-header .nav-link hover underline for real * chore: rename override-v4… * fix: site.css overrides boostrap navbar pad…left * fix: layer project overwrites `project.migration` So, change `project` to `project.core`. * fix: bootstrap 3 styles overriding header * fix: header fix missing on new core-styles v1 site Recent CSS fix for header was only applied to v1-origin sites. The fix should be applied to v4.18+ sites.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrate Frontera project from Core-CMS-Resources.
Status
feat: WP-197 conditional PORTAL_STYLES Core-CMS#880
Not seen on Frontera (cuz it has no such links), but TACC/Core-CMS#856 (for this migration) introduced this bug.
Related
Changes
frontera_assets
Testing
npm ci
npm run build
https://pprd.frontera-portal.tacc.utexas.edu/
https://pprd.frontera-portal.tacc.utexas.edu/system/
https://pprd.frontera-portal.tacc.utexas.edu/training/
https://pprd.frontera-portal.tacc.utexas.edu/…/
UI
Notes
Warning
Loads Core-CMS stylesheet at a version that will not auto-sync with version of Core-CMS being run.
Important
Completed Tasks
v1_v2.css
(since 5e1fb7c)s-article-list
"See all …" / "Learn …" link arrow icon wrongs-article-list
"Learn …" link arrow color swap<h3>
is much thinner (like a Core-Styles v0 site)@mixin
not@extend
buildId
to in options)frontera_assets
Footnotes
Expected style differences: some slightly thinner font weight, icon on system monitor status pill. ↩ ↩2
Content is expected to be different, but within the same layout. Some home page news images on staging do not load (because they hotlink to old TACC site). ↩
Homepage background behind articles in banner should be less gray than production. (This fixes a production bug.) ↩ ↩2