Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #290

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

Added notes to Changelog

PR Status:

  • Ready.

@@ -174,7 +193,10 @@ _No release_

## [2.1] - 2020-10-05

[unreleased]: https://github.com/TACC-Cloud/hazmapper/compare/v2.16...HEAD
[unreleased]: https://github.com/TACC-Cloud/hazmapper/compare/v2.19...HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we listing unreleased branches here? If it is an unreleased WIP, I don't see why it would be added to the change log. Am I missing something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an unused link. It previously was a link but I dropped the display of the link; it is useful to grab this URL when working updates for a new release.

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanfranklin nathanfranklin merged commit cccce3e into main Dec 6, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the hotfix/update-changelog-for-v218-v219 branch December 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants