Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix react deployments #283

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Hotfix/fix react deployments #283

merged 4 commits into from
Nov 15, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Nov 15, 2024 •
edited
Loading

Overview:

Fix react deployments:

  • remove problem 'external' in react/vite.config.ts. That was not needed and snuck in when adding core-components package.
  • add support for exp-react endpoint

PR Status:

  • Ready.

Testing Steps:

  1. Hazmapper of this branch is running on https://hazmapper.tacc.utexas.edu/staging-react and https://hazmapper.tacc.utexas.edu/exp-react

sophia-massie
sophia-massie approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on the deployed envs

@nathanfranklin nathanfranklin merged commit a0b9578 into main Nov 15, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the hotfix/fix-react-deployments branch November 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @sophia-massie