Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/WG-238: follow on #281

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Task/WG-238: follow on #281

merged 6 commits into from
Nov 15, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Nov 12, 2024 •
edited
Loading

Overview:

This PR:

  • updates useDeleteProject to use variables version of useDelete
  • renames isPublic to isPublicView (to make it clear that we are talking about viewing a public map and not just if a map is public)
  • makes the downloaded file have the same name as the map (from
  • updates some tests to use msw (Task/WG-368 improve unit testing of requests #280)

PR Status:

  • Ready.

Related Jira tickets:

sophia-massie
sophia-massie approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests locally LGTM. Thanks for this!

@nathanfranklin nathanfranklin merged commit f79b0cb into main Nov 15, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-238-follow-on branch November 15, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @sophia-massie