Task/WG-238 panel assets listing #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
From #268
nathanfranklin
requested review from
shayanaijaz,
sophia-massie,
taoteg and
rstijerina
Types are included already with antd
4px bottom butter was being added to each node which caused an issue in calculating how much vertical space was needed to render nodes.
sophia-massie
approved these changes
Nov 8, 2024
| const url = window.URL.createObjectURL(blob); | ||
| const link = document.createElement('a'); | ||
| link.href = url; | ||
| link.download = `hazmapper.json`; |
There was a problem hiding this comment.
Should the name of the download reflect the project name so that the user can differentiate downloads?
There was a problem hiding this comment.
Good idea 👍 Doing this in a follow on PR
…oud/hazmapper into task/WG-238-panel-assets-listing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR adds assets listing and download geojson to assets panel
This PR also:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
TODO