Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-396: sqlachemy-update follow on #231

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

This PR provides some changes after the version update and fixes some things that were always an issue with our migration generation.

  • Add models to fix SQLAlchemy 2 autogenerate (auto-generated migration is dropping all tables)
  • Exclude PostGIS-related migrations since PostGIS manages its schema.
  • Add missing migration for spatial index on the_geom (GeoAlchemy2 default).

The last two things were always an issue and not related to version change. The 2nd bullet became more difficult to ignore so fixing here.

Related Jira tickets:

Copy link
Contributor

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with limited knowledge

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test locally

@nathanfranklin nathanfranklin merged commit 4f0b165 into main Dec 11, 2024
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-396-sqlachemy-postgis-follow-on branch December 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants