Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-161-Geoapi-Remove-Kube #183

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Conversation

sophia-massie
Copy link
Contributor

Overview:

Kube cleanup

Related Jira tickets:

Summary of Changes:

  • Removes kube directory
  • Adds new devops/README with deployment and machine information

Testing Steps:

None

Notes:

Can add or remove anything from new devops/README. Open to suggestions.

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Left some suggestions.

devops/README.md Outdated Show resolved Hide resolved
devops/README.md Outdated Show resolved Hide resolved
devops/README.md Show resolved Hide resolved
devops/README.md Outdated Show resolved Hide resolved
devops/README.md Show resolved Hide resolved
Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback, looks good to me otherwise!

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about experimental host, otherwise LGTM!

devops/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophia-massie sophia-massie merged commit 8087488 into main Oct 7, 2024
3 checks passed
@sophia-massie sophia-massie deleted the task/WG-161-GEOAPI-Remove-Kube branch October 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants