task/WG-96: support questionnaires with assets #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 698da33.
Ensure file name is correct and a preview image is created. Also, store info on assets' geolocation
nathanfranklin
commented
Jun 29, 2023
taoteg
reviewed
Oct 13, 2023
taoteg
reviewed
Oct 13, 2023
geoapi/tasks/external_data.py
Outdated
| # determine full path for this asset and add to list | ||
| additional_file_path = current_file_path.with_name(asset["filename"]) | ||
| additional_files_to_get.append(AdditionalFile(path=additional_file_path, required=True)) | ||
| logger.info(f'{len(additional_files_to_get)} assets were found for rq file {current_file.filename}') |
There was a problem hiding this comment.
There is an inconsistency with using single and double quotes through this file. Could we normalize that as much as possible to one of the two?
Compare lines 88, 93, 94, 99, 107, 122, etc.
There was a problem hiding this comment.
I don't know that TACC WMA has a preference but I tend to prefer this usage:
- raw string literals for regular expressions
- single quotes for small symbol-like strings
- double quotes around strings that are used for interpolation or that are natural language messages (break the rules as needed if the strings contain quotes to escape)
- triple double quotes for docstrings
There was a problem hiding this comment.
I took a stab at this in 65eeef8. let me know if that matches up with your comment.
taoteg
approved these changes
Oct 13, 2023
geoapi/tasks/external_data.py
Outdated
| # determine full path for this asset and add to list | ||
| additional_file_path = current_file_path.with_name(asset["filename"]) | ||
| additional_files_to_get.append(AdditionalFile(path=additional_file_path, required=True)) | ||
| logger.info(f'{len(additional_files_to_get)} assets were found for rq file {current_file.filename}') |
There was a problem hiding this comment.
I don't know that TACC WMA has a preference but I tend to prefer this usage:
- raw string literals for regular expressions
- single quotes for small symbol-like strings
- double quotes around strings that are used for interpolation or that are natural language messages (break the rules as needed if the strings contain quotes to escape)
- triple double quotes for docstrings
taoteg
approved these changes
Oct 16, 2023
nathanfranklin
deleted the
task/WG-96-support-questionnaires-with-assets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Support assets in questionnaires.
This PR imports the .rq file and all the associated asset images.
Related Jira tickets:
Testing Steps: