Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TA-Lib binary installed in virtualenv. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for TA-Lib binary installed in virtualenv. #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from distutils.core import setup
from distutils.command.install import install
from distutils.extension import Extension
from Cython.Distutils import build_ext

Expand All @@ -20,6 +21,7 @@
'/usr/local/include',
'/opt/include',
'/opt/local/include',
os.getenv('VIRTUAL_ENV', './venv') + '/include',
]
lib_talib_dirs = [
'/usr/lib',
Expand All @@ -28,6 +30,7 @@
'/usr/local/lib64',
'/opt/lib',
'/opt/local/lib',
os.getenv('VIRTUAL_ENV', './venv') + '/lib',
]
break

Expand Down Expand Up @@ -61,6 +64,12 @@
)
ext_modules.append(ext)

# Hack to install ta-lib library loading into virtualenv
def install_virtualenv_lib_loader():
with open(os.getenv('VIRTUAL_ENV', './venv') + '/bin/activate', 'a') as f:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should check for exists first?

activate = os.getenv('VIRTUAL_ENV', './venv') + '/bin/activate'
if os.path.exists(activate):
    with open(activate) as f:
        f.write("\nexport LD_LIBRARY_PATH=$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH\n")

I have not used virtual env much, but is $VIRTUAL_ENV/lib a standard location for loading libraries, or a workaround for talib? Also, is $VIRTUAL_ENV/bin/activate a standard script that is run?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to detect that we are in a virtual env?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct. Such a check is necessary.

When you create a virtualenv the following standard directory structure appears (bin, include, lib, local, src) and Python binaries and packages get installed into it thereafter. There is no standard location where you create a $VIRTUAL_ENV, some put it in a subdirectory of their project project/venv others directly in project project. Nevertheless this works great for all Python-related things, you just run . venv/bin/activate and use pip install and other things as usual, knowing it will install everything inside the virtualenv. As far as I know the best way to detect a virtualenv is using $VIRTUAL_ENV environment variable.

Unfortunately non-Python libraries are not handled by virtualenv at all. Nevertheless in my setups I usually install them inside the virtualenv directory (./configure --prefix=$VIRTUAL_ENV). This way binaries get installed into ./venv/bin and work automatically (because $PATH is configured correctly by ./venv/bin/activate) and libraries into./venv/lib. After adding a line such asexport LD_LIBRARY_PATH=$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH` they also work as expected.

In case this seems to you as an ugly workaround, you may want to add an option to specify a custom includes and lib folder to search for the TA-Lib (eg. through an environment variable).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a page that talks about using LD_RUN_PATH for this:

https://groups.google.com/forum/#!topic/python-virtualenv/-U4epR1YWFk

Also, not something I expect you to have to work on, but would be nice if it worked on Mac, Linux, and Windows like the talib library does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe it would be great if the Python package would also include (or download) and compile the ta-lib library if it is not installed system-wide? Like some packages do?

f.write("\nexport LD_LIBRARY_PATH=$VIRTUAL_ENV/lib:$LD_LIBRARY_PATH\n")
install_virtualenv_lib_loader()

setup(
name = 'TA-Lib',
version = '0.4.8',
Expand Down